Disable experiment types that do parameter updates if there are no params to update #9007
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all parameters have UPDATE:FALSE set, then we should not let the user select any mode that does parameter updates.
JHolba
added
release-notes:misc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9007 +/- ##
==========================================
- Coverage 91.00% 91.00% -0.01%
==========================================
Files 349 349
Lines 21641 21646 +5
==========================================
+ Hits 19695 19699 +4
- Misses 1946 1947 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think it would be nice to write a test for this. At least the |
xjules
requested changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all parameters have UPDATE:FALSE set, then we should not let the user select any mode that does parameter updates.
Issue
Resolves #8970
Approach
Added a check to see if any parameter has update set to true. If it fails we disable experiment types that do parameter updates.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable